feat: support --gen-suppressions #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When valgrind is run with `--gen-suppressions`, it will write the
error's suppression to XML as something like:
<suppression>
<sname>insert_a_suppression_name_here</sname>
<skind>Memcheck:Leak</skind>
<skaux>match-leak-kinds: definite</skaux>
<sframe> <fun>malloc</fun> </sframe>
<sframe> <fun>objspace_xmalloc0</fun> </sframe>
<sframe> <fun>ruby_xmalloc0</fun> </sframe>
<sframe> <fun>ruby_xmalloc_body</fun> </sframe>
<sframe> <fun>ruby_xmalloc</fun> </sframe>
</suppression>
If this data is present, then ValgrindError will stream it in the
right format for copy-pasting into a suppressions file.
See https://wiki.wxwidgets.org/Valgrind_Suppression_File_Howto for more.
|
👏 Wow! Amazing! This is something that I've wanted to do but haven't gotten around to yet. |
flavorjones
added a commit
to flavorjones/ruby_memcheck
that referenced
this pull request
Dec 7, 2024
Valgrind 3.21.0 will exit if the fd limit is too high. This change is described here: > https://bugs.kde.org/show_bug.cgi?id=465435 A quote from a maintainer in that issue is: "We're not going to change Valgrind to handle insane rlimits that Docker presents", however it looks like Ubuntu 24.10 sets this limit very high: $ uname -a Linux bepi 6.11.0-1004-lowlatency Shopify#4-Ubuntu SMP PREEMPT_DYNAMIC Mon Sep 30 10:54:09 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux $ ulimit -n 1073741816 I suspect this patch will not work on some systems for a variety of reasons, but I wanted to start a conversation about how to address this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When valgrind is run with
--gen-suppressions, it will write theerror's suppression to XML as something like:
If this data is present, then ValgrindError will stream it in the
right format for copy-pasting into a suppressions file.
See https://wiki.wxwidgets.org/Valgrind_Suppression_File_Howto for more.